Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new generate-docs-helm-tests-renovate-pr #10793

Merged

Conversation

armandgrillet
Copy link
Contributor

Testing #10792

@armandgrillet armandgrillet added the invalid This doesn't seem right label Mar 4, 2025
@armandgrillet armandgrillet requested a review from a team as a code owner March 4, 2025 13:39
@armandgrillet armandgrillet reopened this Mar 4, 2025
@armandgrillet armandgrillet removed the invalid This doesn't seem right label Mar 4, 2025
@armandgrillet armandgrillet changed the title Testing new generate-docs-helm-tests-renovate-pr Fix new generate-docs-helm-tests-renovate-pr Mar 4, 2025
@armandgrillet
Copy link
Contributor Author

This worked, as we can see from the last commit b1fa81c which was done automatically by https://github.com/grafana/mimir/actions/runs/13659224117.

I will now delete the line making the CI run even though I was not renovabot and ask for reviews.

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense 🤷 thanks for migrating it

don't we need to add some token to the update_pr step at the bottom too?

@armandgrillet
Copy link
Contributor Author

don't we need to add some token to the update_pr step at the bottom too?

Good question but we don't as we only need the token when pulling content from what I've tested.

Copy link
Contributor

@narqo narqo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@narqo narqo merged commit e69bb95 into main Mar 5, 2025
28 checks passed
@narqo narqo deleted the armandgrillet/test-generate-docs-helm-tests-renovate-pr-flow branch March 5, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants